Co-worker/friend asking for a code review
Could the E-bike drivetrain wear down till needing replacement after 400 km?
Divine apple island
Is there a conventional notation or name for the slip angle?
How much character growth crosses the line into breaking the character
Why we can't differentiate a polynomial equation as many times as we wish?
Folder comparison
Indicating multiple different modes of speech (fantasy language or telepathy)
Gibbs free energy in standard state vs. equilibrium
How can "mimic phobia" be cured or prevented?
Global amount of publications over time
Bob has never been a M before
Why has "pence" been used in this sentence, not "pences"?
Can I sign legal documents with a smiley face?
Is it possible to use .desktop files to open local pdf files on specific pages with a browser?
We have a love-hate relationship
Python script not running correctly when launched with crontab
How should I respond when I lied about my education and the company finds out through background check?
Varistor? Purpose and principle
Has Darkwing Duck ever met Scrooge McDuck?
Drawing a topological "handle" with Tikz
Longest common substring in linear time
Database accidentally deleted with a bash script
A Permanent Norse Presence in America
Query about absorption line spectra
Co-worker/friend asking for a code review
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
add a comment |
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
add a comment |
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
I have a co-worker who I got to know through a mutual friend before we started working for the same company, although he s been working in the company for a year more than me, he was kinda relaxed and didn't take much responsibility and doesn't have a good reputation among his seniors,
I recently joined and worked hard to understand the product better from a technical standpoint and have a better hand at it now.
My colleague recently started developing a feature for the product and is almost set to completion, he now asks me to review his code before going through the formal code-review process, I can see a lot of flaws in his code already and I want him to learn, at the same time I strongly feel that I want to review his code formally just so that people know that I have helped him in coming up with a better code than what he already has, another reason is because I want him to work hard and not have everything spoon-fed to him.
Am I being too selfish here? How should I react to this ?
colleagues software-development
colleagues software-development
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
asked 17 secs ago
Sujith ShivaprakashSujith Shivaprakash
485
485
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "423"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
noCode: true, onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f132419%2fco-worker-friend-asking-for-a-code-review%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to The Workplace Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f132419%2fco-worker-friend-asking-for-a-code-review%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
