May I change the held type in a std::variant from within a call to std::visit2019 Community Moderator ElectionImplementing is_constexpr_copiableHow does std::visit work with std::variant?Visit and invoke a variant of std::functionVisit a variant with a monostateHow to simplify std::variant class typesis decltype required in trailing return using value of argument typeget currently held typeid of std::variant (like boost::variant type())noexcept visitation for std::variantHow to use std::visit with std::variant containing enumPredefined type list passed to a std::variant
In a future war, an old lady is trying to raise a boy but one of the weapons has made everyone deaf
What is the significance behind "40 days" that often appears in the Bible?
Brexit - No Deal Rejection
Time travel from stationary position?
Do I need to be arrogant to get ahead?
Stiffness of a cantilever beam
Define, (actually define) the "stability" and "energy" of a compound
Pólya urn flip and roll
Are all passive ability checks floors for active ability checks?
Is it normal that my co-workers at a fitness company criticize my food choices?
How to create the Curved texte?
Happy pi day, everyone!
Python if-else code style for reduced code
Does Mathematica reuse previous computations?
How do anti-virus programs start at Windows boot?
What approach do we need to follow for projects without a test environment?
Official degrees of earth’s rotation per day
Who is flying the vertibirds?
What should tie a collection of short-stories together?
What's causing this power spike in STM32 low power mode
Are there other languages, besides English, where the indefinite (or definite) article varies based on sound?
AG Cluster db upgrade by vendor
Can I use USB data pins as power source
Why does Bach not break the rules here?
May I change the held type in a std::variant from within a call to std::visit
2019 Community Moderator ElectionImplementing is_constexpr_copiableHow does std::visit work with std::variant?Visit and invoke a variant of std::functionVisit a variant with a monostateHow to simplify std::variant class typesis decltype required in trailing return using value of argument typeget currently held typeid of std::variant (like boost::variant type())noexcept visitation for std::variantHow to use std::visit with std::variant containing enumPredefined type list passed to a std::variant
Does the following code invoke undefined behaviour?
std::variant<A,B> v = ...;
std::visit([&v](auto& e)
if constexpr (std::is_same_v<std::remove_reference_t<decltype(e)>,A>)
e.some_modifying_operation_on_A();
else
int i = e.some_accessor_of_B();
v = some_function_returning_A(i);
, v);
In particular, when the variant does not contain an A,
this code re-assigns an A while still holding a reference to the previously held object of type B.
However, because the reference is not used anymore after the assignment,
I feel the code is fine.
However, would a standard-library be free to implement std::visit
in a way such that the above is undefined behaviour?
c++ c++17 std-variant
edited 3 hours ago
Barry
184k21323594
asked 4 hours ago
burnpanckburnpanck
1,131622
add a comment |
Does the following code invoke undefined behaviour?
std::variant<A,B> v = ...;
std::visit([&v](auto& e)
if constexpr (std::is_same_v<std::remove_reference_t<decltype(e)>,A>)
e.some_modifying_operation_on_A();
else
int i = e.some_accessor_of_B();
v = some_function_returning_A(i);
, v);
In particular, when the variant does not contain an A,
this code re-assigns an A while still holding a reference to the previously held object of type B.
However, because the reference is not used anymore after the assignment,
I feel the code is fine.
However, would a standard-library be free to implement std::visit
in a way such that the above is undefined behaviour?
c++ c++17 std-variant
edited 3 hours ago
Barry
184k21323594
asked 4 hours ago
burnpanckburnpanck
1,131622
5
Do you want quotes from the standard to back up the answer(s) you get?
– NathanOliver
4 hours ago
1
From looking at [variant.visit], I'm 99% sure this code is compliant and guaranteed not to have UB, sincestd::visit(vis, variant)should be equivalent tovis(get</* active member */>(variant)), but I'm not confident enough in reading the standard to be certain
– Justin
3 hours ago
@NathanOliver: I don't need actual quotes from the standard, as long as the experts here can agree on the answer:-).
– burnpanck
3 hours ago
add a comment |
Does the following code invoke undefined behaviour?
std::variant<A,B> v = ...;
std::visit([&v](auto& e)
if constexpr (std::is_same_v<std::remove_reference_t<decltype(e)>,A>)
e.some_modifying_operation_on_A();
else
int i = e.some_accessor_of_B();
v = some_function_returning_A(i);
, v);
In particular, when the variant does not contain an A,
this code re-assigns an A while still holding a reference to the previously held object of type B.
However, because the reference is not used anymore after the assignment,
I feel the code is fine.
However, would a standard-library be free to implement std::visit
in a way such that the above is undefined behaviour?
c++ c++17 std-variant
edited 3 hours ago
Barry
184k21323594
asked 4 hours ago
burnpanckburnpanck
1,131622
Does the following code invoke undefined behaviour?
std::variant<A,B> v = ...;
std::visit([&v](auto& e)
if constexpr (std::is_same_v<std::remove_reference_t<decltype(e)>,A>)
e.some_modifying_operation_on_A();
else
int i = e.some_accessor_of_B();
v = some_function_returning_A(i);
, v);
In particular, when the variant does not contain an A,
this code re-assigns an A while still holding a reference to the previously held object of type B.
However, because the reference is not used anymore after the assignment,
I feel the code is fine.
However, would a standard-library be free to implement std::visit
in a way such that the above is undefined behaviour?
c++ c++17 std-variant
c++ c++17 std-variant
edited 3 hours ago
Barry
184k21323594
asked 4 hours ago
burnpanckburnpanck
1,131622
edited 3 hours ago
Barry
184k21323594
asked 4 hours ago
burnpanckburnpanck
1,131622
edited 3 hours ago
Barry
184k21323594
edited 3 hours ago
Barry
184k21323594
edited 3 hours ago
Barry
184k21323594
184k21323594
asked 4 hours ago
burnpanckburnpanck
1,131622
asked 4 hours ago
burnpanckburnpanck
1,131622
asked 4 hours ago
burnpanckburnpanck
1,131622
1,131622
5
Do you want quotes from the standard to back up the answer(s) you get?
– NathanOliver
4 hours ago
1
From looking at [variant.visit], I'm 99% sure this code is compliant and guaranteed not to have UB, sincestd::visit(vis, variant)should be equivalent tovis(get</* active member */>(variant)), but I'm not confident enough in reading the standard to be certain
– Justin
3 hours ago
@NathanOliver: I don't need actual quotes from the standard, as long as the experts here can agree on the answer:-).
– burnpanck
3 hours ago
add a comment |
5
Do you want quotes from the standard to back up the answer(s) you get?
– NathanOliver
4 hours ago
1
From looking at [variant.visit], I'm 99% sure this code is compliant and guaranteed not to have UB, sincestd::visit(vis, variant)should be equivalent tovis(get</* active member */>(variant)), but I'm not confident enough in reading the standard to be certain
– Justin
3 hours ago
@NathanOliver: I don't need actual quotes from the standard, as long as the experts here can agree on the answer:-).
– burnpanck
3 hours ago
5
5
Do you want quotes from the standard to back up the answer(s) you get?
– NathanOliver
4 hours ago
Do you want quotes from the standard to back up the answer(s) you get?
– NathanOliver
4 hours ago
1
1
From looking at [variant.visit], I'm 99% sure this code is compliant and guaranteed not to have UB, since
std::visit(vis, variant) should be equivalent to vis(get</* active member */>(variant)), but I'm not confident enough in reading the standard to be certain– Justin
3 hours ago
From looking at [variant.visit], I'm 99% sure this code is compliant and guaranteed not to have UB, since
std::visit(vis, variant) should be equivalent to vis(get</* active member */>(variant)), but I'm not confident enough in reading the standard to be certain– Justin
3 hours ago
@NathanOliver: I don't need actual quotes from the standard, as long as the experts here can agree on the answer:-).
– burnpanck
3 hours ago
@NathanOliver: I don't need actual quotes from the standard, as long as the experts here can agree on the answer:-).
– burnpanck
3 hours ago
add a comment |
1 Answer
1
active
oldest
votes
The code is fine.
There is no requirement in the specification of std::visit that the visitor not change the alternative of any of the variants it is invoked on. The only requirement is:
Requires: For each valid pack
m,e(m)shall be a valid expression. All such expressions shall be of the same type and value category; otherwise, the program is ill-formed.
Your visitor is a valid expression for each m and always returns void, so it satisfies the requirements and has well-defined behavior.
answered 3 hours ago
BarryBarry
184k21323594
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55187548%2fmay-i-change-the-held-type-in-a-stdvariant-from-within-a-call-to-stdvisit%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
The code is fine.
There is no requirement in the specification of std::visit that the visitor not change the alternative of any of the variants it is invoked on. The only requirement is:
Requires: For each valid pack
m,e(m)shall be a valid expression. All such expressions shall be of the same type and value category; otherwise, the program is ill-formed.
Your visitor is a valid expression for each m and always returns void, so it satisfies the requirements and has well-defined behavior.
answered 3 hours ago
BarryBarry
184k21323594
add a comment |
The code is fine.
There is no requirement in the specification of std::visit that the visitor not change the alternative of any of the variants it is invoked on. The only requirement is:
Requires: For each valid pack
m,e(m)shall be a valid expression. All such expressions shall be of the same type and value category; otherwise, the program is ill-formed.
Your visitor is a valid expression for each m and always returns void, so it satisfies the requirements and has well-defined behavior.
answered 3 hours ago
BarryBarry
184k21323594
add a comment |
The code is fine.
There is no requirement in the specification of std::visit that the visitor not change the alternative of any of the variants it is invoked on. The only requirement is:
Requires: For each valid pack
m,e(m)shall be a valid expression. All such expressions shall be of the same type and value category; otherwise, the program is ill-formed.
Your visitor is a valid expression for each m and always returns void, so it satisfies the requirements and has well-defined behavior.
answered 3 hours ago
BarryBarry
184k21323594
The code is fine.
There is no requirement in the specification of std::visit that the visitor not change the alternative of any of the variants it is invoked on. The only requirement is:
Requires: For each valid pack
m,e(m)shall be a valid expression. All such expressions shall be of the same type and value category; otherwise, the program is ill-formed.
Your visitor is a valid expression for each m and always returns void, so it satisfies the requirements and has well-defined behavior.
answered 3 hours ago
BarryBarry
184k21323594
answered 3 hours ago
BarryBarry
184k21323594
answered 3 hours ago
BarryBarry
184k21323594
answered 3 hours ago
BarryBarry
184k21323594
184k21323594
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55187548%2fmay-i-change-the-held-type-in-a-stdvariant-from-within-a-call-to-stdvisit%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
5
Do you want quotes from the standard to back up the answer(s) you get?
– NathanOliver
4 hours ago
1
From looking at [variant.visit], I'm 99% sure this code is compliant and guaranteed not to have UB, since
std::visit(vis, variant)should be equivalent tovis(get</* active member */>(variant)), but I'm not confident enough in reading the standard to be certain– Justin
3 hours ago
@NathanOliver: I don't need actual quotes from the standard, as long as the experts here can agree on the answer:-).
– burnpanck
3 hours ago